Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable non-public address port mapping announcement #771

Merged
merged 1 commit into from
Jan 16, 2020
Merged

enable non-public address port mapping announcement #771

merged 1 commit into from
Jan 16, 2020

Conversation

optman
Copy link
Contributor

@optman optman commented Jan 15, 2020

Announce both non-public port mapping address and observed address.
Fixes #769

Stebalien
Stebalien approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit c615fa0 into libp2p:master Jan 16, 2020
@optman optman deleted the fix-port-mapping branch January 16, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port mapping issue with nat behind nat
2 participants
@optman @Stebalien